Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Align list item do not change the export DOM #5160

Conversation

trinhvinhtruong96
Copy link
Contributor

@trinhvinhtruong96 trinhvinhtruong96 commented Oct 24, 2023

This pull request related to #5159
Lexical version:
V0.12.2

Steps To Reproduce

  1. Click Bulleted List button
    image
  2. Type something
    image
  3. Click export DOM button, look at the DOM
    image
  4. Click on the text and then click Right Align button
    image
  5. Look at the DOM
    image

Link to code example:
https://playground.lexical.dev/

The current behavior

The DOM do not change after click Right Align button

The expected behavior

The right align style should be applied into the list item DOM

@facebook-github-bot
Copy link
Contributor

Hi @trinhvinhtruong96!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 9:27am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 9:27am

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2023
@ivailop7
Copy link
Collaborator

For @acywatson to confirm if happy with this approach

@thegreatercurve
Copy link
Contributor

This approach should be fine. We do something similar in ParagraphNode

@thegreatercurve
Copy link
Contributor

Closes #5160

@thegreatercurve thegreatercurve merged commit 37aeced into facebook:main Nov 15, 2023
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants