Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue 5181 where link address is not shown if comment is set in… #5188

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

btezzxxt
Copy link
Contributor

@btezzxxt btezzxxt commented Nov 1, 2023

as title fix #5181

Screen.Recording.2023-11-01.at.5.24.54.PM.mov

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 1, 2023
Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 11:02pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 11:02pm

Copy link

github-actions bot commented Nov 1, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 37.14 KB (0%) 743 ms (0%) 47 ms (-6.75% 🔽) 790 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.96 KB (0%) 800 ms (0%) 61 ms (+46.28% 🔺) 860 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 39.94 KB (0%) 799 ms (0%) 74 ms (+80.46% 🔺) 872 ms

Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment but otherwise LGTM, thank you!

@btezzxxt btezzxxt merged commit 53f55ae into main Nov 1, 2023
40 of 45 checks passed
@btezzxxt btezzxxt deleted the link-hoverover-not-showing-address-on-comments branch November 1, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Can't see link url if comment is set inside link node.
3 participants