Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix $convertFromMarkdownString breakdown due to no parent #5393

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

2wheeh
Copy link
Contributor

@2wheeh 2wheeh commented Dec 14, 2023

Fixes #5385

please check the comment.

thank you.

before:
https://github.com/facebook/lexical/issues/5385#:~:text=before%2D-,convertfrommarkdown,-.mov

after:

2023-12-15.4.59.24.mov

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2023 7:28pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2023 7:28pm

@acywatson acywatson merged commit dc8cbab into facebook:main Dec 21, 2023
45 checks passed
@2wheeh 2wheeh deleted the text-match-robust-simple branch December 22, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: $convertFromMarkdownString triggers the breakdown of the editor
3 participants