Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct custom node examples #5407

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

inaseem
Copy link
Contributor

@inaseem inaseem commented Dec 20, 2023

I noticed the examples for CustomParagraph had incorrect types on constructor and few imports were also missing in Nodes page. Since those are copy paste sample, the examples should just work without any modification. Corrected the types and added the missing import in them.

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 5:24pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 5:24pm

@facebook-github-bot
Copy link
Contributor

Hi @inaseem!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2023
@acywatson
Copy link
Contributor

Thank you!

@acywatson acywatson merged commit 7eaf70c into facebook:main Dec 24, 2023
5 checks passed
@inaseem inaseem deleted the fix/custom-node-example branch December 25, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants