Revert "Fixed position for lexical menu (#5602)" #5614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0ebb413.
zurfyx
requested review from
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
thegreatercurve
approved these changes
Feb 15, 2024
This issue doesn't have anything to do with my PR, and existed before my change. I can fix it in a separate PR. |
|
The wrong positioning of typeahead menu on scroll started from #5187 |
sqs
added a commit
to sourcegraph/lexical
that referenced
this pull request
Aug 14, 2024
)" facebook#5187 This reverts commit dc2da3a. It was causing an issue where the @-mention menu would immediately disappear in Cody's message field because the anchor would be outside of the `.editor-scroller`. Other users seem to be seeing similar issues (facebook#5614 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting as the menu does not work correctly when the page is scrolled. If you scroll down the entire viewport, the menu doesn't even show.
Screen.Recording.2024-02-15.at.9.11.55.AM.mov
@ebads67 can you share more details on your use case and we can follow up in a separate PR?
This reverts commit 0ebb413.