Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shift+arrow down selection for tables in sequence. #5617

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

serey-roth
Copy link
Contributor

Before:

table-sequence-selection-before.webm

After:

table-sequence-selection-after.webm

Fixes #5616.

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 10:02pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 10:02pm

@facebook-github-bot
Copy link
Contributor

Hi @serey-roth!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@serey-roth serey-roth changed the title Ensure isAnchorInside and isFocusInside are boolean values. Fix shift+arrow down selection for tables in sequence. Feb 15, 2024
@ivailop7
Copy link
Collaborator

@serey-roth please sign the CLA and it looks good to go

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 16, 2024
@ivailop7 ivailop7 merged commit 4956b4f into facebook:main Feb 17, 2024
40 of 45 checks passed
@serey-roth serey-roth deleted the serey/table-sequence/selection branch July 11, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: shift + arrow down selects only the first table in sequence.
3 participants