Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code snippets for ClearEditorPlugin and MarkdownShortcutPlugin #5711

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

NickRawls
Copy link
Contributor

Adding missing code snippets for ClearEditorPlugin and MarkdownShortcutPlugin in react plugin.md and fixing typo in same file

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 4:03am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 4:03am

@facebook-github-bot
Copy link
Contributor

Hi @NickRawls!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@acywatson
Copy link
Contributor

Beaut! If you sign the CLA, we'll merge it in :)

@NickRawls
Copy link
Contributor Author

Beaut! If you sign the CLA, we'll merge it in :)

Thanks @acywatson ! I signed the CLA a couple of hours ago (~10:16AM CST). The form says the check should update the PR within 1 hour, so I'm not sure if it needs to be triggered again.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 14, 2024
@acywatson acywatson merged commit f2b239e into facebook:main Mar 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants