Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't call importDOM methods more than once #5726

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

thorn0
Copy link
Contributor

@thorn0 thorn0 commented Mar 17, 2024

I didn't add this check, only fixed it.

Copy link

vercel bot commented Mar 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2024 8:37pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2024 8:37pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2024
Copy link
Collaborator

@ivailop7 ivailop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice one! Good catch!

@ivailop7 ivailop7 merged commit 1475590 into facebook:main Mar 17, 2024
45 checks passed
@thorn0 thorn0 deleted the fix-import-dom-check branch March 18, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants