Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build script to exclude WWW from ESM modules #5753

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Update build script to exclude WWW from ESM modules #5753

merged 1 commit into from
Mar 22, 2024

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Mar 22, 2024 •
edited
Loading

Haste doesn't work well with ESM modules, especially minified prod builds.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 22, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 11:24am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2024 11:24am

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.76 KB (0%) 536 ms (0%) 97 ms (+682.34% 🔺) 632 ms
packages/lexical-rich-text/dist/LexicalRichText.js 38.87 KB (0%) 778 ms (0%) 113 ms (+200.79% 🔺) 890 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 38.84 KB (0%) 777 ms (0%) 96 ms (+235.98% 🔺) 873 ms

@thegreatercurve thegreatercurve marked this pull request as ready for review March 22, 2024 10:43
@thegreatercurve thegreatercurve changed the title Update build script to exclude WWW from ESM modules [WIP] Update build script to exclude WWW from ESM modules Mar 22, 2024
@thegreatercurve thegreatercurve changed the title [WIP] Update build script to exclude WWW from ESM modules Update build script to exclude WWW from ESM modules Mar 22, 2024
@thegreatercurve thegreatercurve merged commit 7d7188f into main Mar 22, 2024
43 of 45 checks passed
@dmitrymarokhonov dmitrymarokhonov mentioned this pull request May 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fetz Fetz Fetz approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thegreatercurve @Fetz @facebook-github-bot