Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection started from inside of the table #5766

Merged

Conversation

AlexanderReznik
Copy link
Contributor

@AlexanderReznik AlexanderReznik commented Mar 26, 2024

Making it possible to select content beyond the table when starting the selection from inside of the table. In this case the whole table becomes selected similar to the case when selection starts from outside of the table and goes inside. Table selection is replaced with the Range selection
Before:
table selection before
After:
table selection after

Allowing to drag a selection from one table to the other without crashing
Fixes the following error:
2 tables crash

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 2:56pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 2:56pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 26, 2024
@ivailop7
Copy link
Collaborator

Thank you, Alex! @zurfyx @acywatson @fantactuka can you give this one a look?

@zurfyx
Copy link
Member

zurfyx commented Mar 28, 2024

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants