Respect CSS zoom #5772
Merged
Respect CSS zoom #5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
ebads67
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
Looking very good! Thanks for fixing! Integrity fails because of prettier formatting. |
zurfyx
approved these changes
Mar 28, 2024
Daniel15
reviewed
Apr 1, 2024
| * @param element | ||
| */ | ||
| export function calculateZoomLevel(element: Element | null): number { | ||
| if (IS_FIREFOX) { |
There was a problem hiding this comment.
Should this do feature detection rather than browser detection?
Interesting, I didn't realise they finally implemented it. The bug tracking its implementation is 17 years old: https://bugzilla.mozilla.org/show_bug.cgi?id=390936 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Css
zoomproperty affects the mouse position inevents. However, functions likegetBoundingClientRectdo not care about the csszoom. Hence, the calculations that use mouse positions andgetBoundingClientRectreturn wrong values. In this PR those calculations are fixed to return the correct value when csszoomproperty is used.Css
zoomhas only been implemented in Nightly version of Firefox. So the fix does not apply to Firefox.In all the examples below the css
zoomproperty is set to 2 on the body of the document..Issue with checklist interactions:
Issue with drag handle:
Issue with context menu: