Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore playground esm build #5781

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

etrepum
Copy link
Collaborator

@etrepum etrepum commented Mar 29, 2024

The /esm/ build of the playground added in #5618 was reverted by the #5744 vite config refactor. This adds it back using the same strategy of a sibling module to avoid code duplication.

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 7:23pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 7:23pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 29, 2024
@ivailop7
Copy link
Collaborator

@StyleT can you have a look at this one?

@etrepum

This comment was marked as resolved.

@etrepum
Copy link
Collaborator Author

etrepum commented Mar 29, 2024

Should be working again at https://lexical-playground-8rmebjq2j-fbopensource.vercel.app/esm/ (edit: fixed link)

Copy link
Collaborator

@ivailop7 ivailop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acywatson acywatson merged commit 111117d into facebook:main Mar 29, 2024
45 checks passed
@etrepum etrepum deleted the playground-esm-build branch May 11, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants