Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5543 insertText('') was inserting Text as child of "table node" instead of root before tablerow resulting in table node not getting deleted #5799

Merged
merged 9 commits into from
Apr 2, 2024
Merged

Fix #5543 insertText('') was inserting Text as child of "table node" instead of root before tablerow resulting in table node not getting deleted #5799

merged 9 commits into from
Apr 2, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented Apr 1, 2024

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 1, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 8:09am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 8:09am

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.77 KB (0%) 536 ms (0%) 225 ms (+1491.35% 🔺) 760 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.01 KB (0%) 781 ms (0%) 296 ms (+639.68% 🔺) 1.1 s
packages/lexical-plain-text/dist/LexicalPlainText.js 38.98 KB (0%) 780 ms (0%) 275 ms (+520.78% 🔺) 1.1 s

@Sahejkm Sahejkm merged commit 2b2a4f6 into main Apr 2, 2024
45 checks passed
@Sahejkm Sahejkm deleted the 5543_sahej branch May 7, 2024 16:27
@dmitrymarokhonov dmitrymarokhonov mentioned this pull request May 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sahejkm @zurfyx @facebook-github-bot