#4618 combine list if next sibling is list node

[potatowagon]

Fix for issue 4618
Before
see #4618

After

Screen.Recording.2024-04-02.at.2.08.44.PM.mov

^list of same types merged

^ lists of different types not merged

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 2, 2024 9:34am
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 2, 2024 9:34am

[acywatson]

Wow, I really thought we were already doing this somewhere.

I guess we only did it on insertion before:

https://github.com/facebook/lexical/pull/4386/files#diff-1468d7969b0009bad1b71c705004bb333f3ac0c41ca26f76527f5d32e61c9f86R220

I wonder if we can remove that code now, and handle it all here.

[potatowagon]

oh cool thanks @acywatson for the code pointer

Wow, I really thought we were already doing this somewhere.

I guess we only did it on insertion before:

https://github.com/facebook/lexical/pull/4386/files#diff-1468d7969b0009bad1b71c705004bb333f3ac0c41ca26f76527f5d32e61c9f86R220

I wonder if we can remove that code now, and handle it all here.

by here do u mean handling the list merging in this part:

lexical/packages/lexical-list/src/LexicalListItemNode.ts

Line 229 in 7fa68b5

// Attempt to merge if the list is of the same type.

or do it as per this PR and remove the merging logic at the above code pointer (inside LexicalListItemNode)?

[potatowagon]

ill merge this PR first and delete the duplicate list merge logic in another PR so its easier to test for any regressions

[potatowagon]

addressed in #5810 5810

[acywatson]

oh cool thanks @acywatson for the code pointer

Wow, I really thought we were already doing this somewhere.
I guess we only did it on insertion before:
https://github.com/facebook/lexical/pull/4386/files#diff-1468d7969b0009bad1b71c705004bb333f3ac0c41ca26f76527f5d32e61c9f86R220
I wonder if we can remove that code now, and handle it all here.

by here do u mean handling the list merging in this part:

lexical/packages/lexical-list/src/LexicalListItemNode.ts

Line 229 in 7fa68b5

// Attempt to merge if the list is of the same type.

or do it as per this PR and remove the merging logic at the above code pointer (inside LexicalListItemNode)?

Yes, you correctly interpreted my intent. Thank you!