Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with removing selectionchange correctly #5848

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Fix issue with removing selectionchange correctly #5848

merged 2 commits into from
Apr 8, 2024

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Apr 8, 2024 •
edited
Loading

The latter check should actually be for '0'.

@vercel Vercel
Copy link

vercel bot commented Apr 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 2:37pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 2:37pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 8, 2024
@thegreatercurve thegreatercurve marked this pull request as ready for review April 8, 2024 14:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.95 KB (0%) 539 ms (0%) 106 ms (+307.3% 🔺) 645 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.37 KB (+0.02% 🔺) 788 ms (+0.02% 🔺) 122 ms (+33.92% 🔺) 910 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 39.34 KB (+0.01% 🔺) 787 ms (+0.01% 🔺) 100 ms (+39.15% 🔺) 887 ms

@thegreatercurve thegreatercurve merged commit d306095 into main Apr 8, 2024
45 checks passed
@thegreatercurve thegreatercurve changed the title Fix issue with removeing selectionchange correctly Fix issue with removing selectionchange correctly Apr 8, 2024
@thegreatercurve thegreatercurve deleted the bug/selection-bug-2 branch April 8, 2024 14:55
@acywatson acywatson mentioned this pull request Apr 16, 2024
Merged
@dmitrymarokhonov dmitrymarokhonov mentioned this pull request May 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantactuka fantactuka fantactuka approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thegreatercurve @fantactuka @facebook-github-bot