Add $ prefix to updateToolbar on react-rich example #5887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2wheeh
requested review from
zurfyx,
fantactuka,
acywatson and
Fetz
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
|
related discussion about $ prefix: #1800 (comment) |
potatowagon
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
makes sense to prefix $ since the fn touches the editor state
cross reference: $ is prefixed here in a similar usecase: https://github.com/facebook/lexical/blame/a951969b63e03717ee28f30fdae15a7805e94bd8/packages/lexical-playground/src/plugins/ToolbarPlugin/index.tsx#L549
theres also
which could benefit from this change too
lgtm!
|
@potatowagon hi, looks like your last comment might have landed on the wrong PR 😋 |
haha oh dear silly me thanks for letting me know! 😅 |
StyleT
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should this be with $ prefix ?