Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with block decorator nodes erroring on indent #5923

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix bug with block decorator nodes erroring on indent #5923

merged 1 commit into from
Apr 22, 2024

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Apr 18, 2024 •
edited
Loading

Closes #5650.

Test Plan

Ensure no errors appear when trying to indent a block decorator node.

image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 18, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 8:45pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 8:45pm

@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.65 KB (0%) 473 ms (0%) 288 ms (+6.93% 🔺) 761 ms
packages/lexical-rich-text/dist/LexicalRichText.js 33.81 KB (0%) 677 ms (0%) 1.3 s (+54.42% 🔺) 2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 33.75 KB (0%) 676 ms (0%) 958 ms (+9.76% 🔺) 1.7 s

@thegreatercurve thegreatercurve marked this pull request as ready for review April 18, 2024 20:44
@thegreatercurve thegreatercurve merged commit 490389d into main Apr 22, 2024
45 checks passed
@thegreatercurve thegreatercurve deleted the bug/indent-block-decorator-nodes branch April 22, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Indenting a DecoratorNode (ie TweetNode) causes exception and makes editor unresponsive.
3 participants
@thegreatercurve @ivailop7 @facebook-github-bot