Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font size update in table selection #6046

Merged
merged 1 commit into from
May 7, 2024

Conversation

Shubhankerism
Copy link
Collaborator

This PR fixes the issue with font size not updating with the +/- buttons when there's a table selection with the cells having text with the same font size.
The $getSelectionStyleValueForProperty method was not returning the correct updated font size for table selection hence the size updates didn't apply correctly.

Before

table-font-size-before

After

table-font-size-after

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 7, 2024
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 1:35pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 1:35pm

Copy link
Collaborator

@ivailop7 ivailop7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivailop7 ivailop7 merged commit fb3a963 into facebook:main May 7, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants