Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lexical] Use classic mode for jsx runtime for meta build #6134

Merged
merged 2 commits into from
May 18, 2024
Merged

[Lexical] Use classic mode for jsx runtime for meta build #6134

merged 2 commits into from
May 18, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented May 18, 2024

  • Use classic mode for jsx runtime for meta build
  • fix build getting exception for react/jsx-runtime module doesn't exist, use classic mode for the build

@vercel Vercel
Copy link

vercel bot commented May 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 5:29am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 5:29am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 18, 2024
@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.91 KB (0%) 479 ms (0%) 719 ms (+89.12% 🔺) 1.2 s
packages/lexical-rich-text/dist/LexicalRichText.js 34.6 KB (0%) 693 ms (0%) 1.5 s (+10.2% 🔺) 2.2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 34.51 KB (0%) 691 ms (0%) 1.3 s (+28% 🔺) 2 s

@Sahejkm Sahejkm marked this pull request as ready for review May 18, 2024 06:40
@github-actions github-actions bot added the extended-tests Run extended e2e tests on a PR label May 18, 2024
@etrepum
Copy link
Collaborator

etrepum commented May 18, 2024

Test failure looks like a flaky collab run

@Sahejkm Sahejkm added this pull request to the merge queue May 18, 2024
Merged via the queue into main with commit cf6b9ef May 18, 2024
46 of 48 checks passed
@etrepum etrepum mentioned this pull request May 20, 2024
Merged
This was referenced Jun 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StyleT StyleT StyleT approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sahejkm @etrepum @StyleT @facebook-github-bot