Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tbody and thead tags to TableObserver #6139

Merged
merged 2 commits into from
May 21, 2024
Merged

Add tbody and thead tags to TableObserver #6139

merged 2 commits into from
May 21, 2024

Conversation

Piechota
Copy link
Contributor

I ran into an issue when I tried to create table like:

<table>
   <colgroup>
   .....
   </colgroup>
   <tbody>
   ....
   </tbody>
</table>

I created one ElementNode with


one TextNode with
and TableNode with

but it didn't update values in TableObserver and table didn't work correctly.
This PR fixes it.

@vercel Vercel
Copy link

vercel bot commented May 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 11:28pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 11:28pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 19, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.93 KB (0%) 479 ms (0%) 180 ms (+337.42% 🔺) 658 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.53 KB (0%) 691 ms (0%) 148 ms (+32.75% 🔺) 839 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 34.59 KB (0%) 692 ms (0%) 189 ms (+116.45% 🔺) 881 ms

ivailop7
ivailop7 previously approved these changes May 21, 2024
View reviewed changes
@ivailop7 ivailop7 added the extended-tests Run extended e2e tests on a PR label May 21, 2024
ivailop7
ivailop7 reviewed May 21, 2024
View reviewed changes
packages/lexical-table/src/LexicalTableObserver.ts
nodeName === 'TABLE' ||
nodeName === 'TBODY' ||
nodeName === 'TR'
) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by this logic, shouldn't THEAD be included as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point
added it

@ivailop7 ivailop7 mentioned this pull request May 21, 2024
Closed
@ivailop7 ivailop7 changed the title Add tbody tag Add tbody and thead tags to TableObserver May 21, 2024
@ivailop7 ivailop7 added this pull request to the merge queue May 21, 2024
Merged via the queue into facebook:main with commit b2699b1 May 21, 2024
41 checks passed
@Piechota Piechota deleted the add-tbody branch May 22, 2024 00:26
This was referenced Jun 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop7 ivailop7 ivailop7 approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Piechota @ivailop7 @facebook-github-bot