Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lexical] add null check for key undefined before calling toLowerCase function #6154

Merged
merged 3 commits into from
May 21, 2024
Merged

[Lexical] add null check for key undefined before calling toLowerCase function #6154

merged 3 commits into from
May 21, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented May 21, 2024

  • add null check for key undefined before calling toLowerCase function
  • recently see some crashes related to calling toLowercase on undefined, add null check to avoid errors

@vercel Vercel
Copy link

vercel bot commented May 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 8:48am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 8:48am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 23.93 KB (+0.07% 🔺) 479 ms (+0.07% 🔺) 161 ms (-0.16% 🔽) 640 ms
packages/lexical-rich-text/dist/LexicalRichText.js 34.53 KB (-0.23% 🔽) 691 ms (-0.23% 🔽) 400 ms (-8% 🔽) 1.1 s
packages/lexical-plain-text/dist/LexicalPlainText.js 34.59 KB (+0.24% 🔺) 692 ms (+0.24% 🔺) 470 ms (-0.85% 🔽) 1.2 s

@Sahejkm Sahejkm marked this pull request as ready for review May 21, 2024 08:49
@github-actions github-actions bot added the extended-tests Run extended e2e tests on a PR label May 21, 2024
@Sahejkm Sahejkm added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 6b4c1dc May 21, 2024
41 of 43 checks passed
This was referenced Jun 26, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sahejkm @zurfyx @facebook-github-bot