[lexical-list][lexical-playground] Bug fix: support pasting google doc checklist #6191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potatowagon
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
potatowagon
force-pushed
the
fix-checkbox-paste
branch
from
81da044
to
9740918
Compare
potatowagon
force-pushed
the
fix-checkbox-paste
branch
from
9740918
to
0fc8fc4
Compare
potatowagon
changed the title
potatowagon
force-pushed
the
fix-checkbox-paste
branch
from
81bedf9
to
0b52e13
Compare
ivailop7
previously approved these changes
May 29, 2024
StyleT
reviewed
May 29, 2024
| img.parentElement != null && | ||
| img.parentElement.tagName === 'LI' && | ||
| img.previousSibling === null && | ||
| img.src.startsWith('data:image/png;base64,iVBOR') |
There was a problem hiding this comment.
this image node has roledescription="checkbox" IMO it's better to check for it rather then performing base64 match
zurfyx
previously approved these changes
May 29, 2024
Comment on lines
498
to
503
| isHTMLElement(domNode) && | ||
| (domNode.getAttribute('aria-checked') === 'true' | ||
| ? true | ||
| : domNode.getAttribute('aria-checked') === 'false' | ||
| ? false | ||
| : undefined); |
There was a problem hiding this comment.
Why is the undefined important here? Nit, can we simplify this nested ternary? We can even retrieve the getAttribute once which saves us from a second getAttribute call
There was a problem hiding this comment.
the undefined is for non checkbox cases, eg. bullet list. sure will save the getAttribute as var
StyleT
approved these changes
May 29, 2024
|
test failures are from flaky test & unrelated to PR changes. double check on main the same tests fail |
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support pasting google doc checklist
Closes #6022
Test plan
added unit test
Before
^ the checkboxes are img so unusable
After