Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-list] Bug fix: support pasting github checklist #6195

Merged
merged 7 commits into from
May 30, 2024
Merged

[lexical-list] Bug fix: support pasting github checklist #6195

merged 7 commits into from
May 30, 2024

Conversation

potatowagon
Copy link
Contributor

@potatowagon potatowagon commented May 29, 2024 •
edited
Loading

Description

pasting from github checklist currently doesnt work

Test plan

testcase, copy and paste

checklist

  • done
  • todo

Before

Screenshot 2024-05-29 at 4 24 47 PM

After

Screenshot 2024-05-29 at 4 24 34 PM

@vercel Vercel
Copy link

vercel bot commented May 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 6:25am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 6:25am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 29, 2024
@potatowagon potatowagon marked this pull request as draft May 29, 2024 05:52
@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/lexical/dist/Lexical.js 23.95 KB (0%)
packages/lexical-rich-text/dist/LexicalRichText.js 34.64 KB (0%)
packages/lexical-plain-text/dist/LexicalPlainText.js 34.62 KB (0%)

@potatowagon
Copy link
Contributor Author

potatowagon commented May 29, 2024 •
edited
Loading

checklist

  • done
  • todo

@potatowagon potatowagon changed the title Gh cb paste [lexical-list][lexical-playground] Bug fix: support pasting github checklist May 29, 2024
@potatowagon potatowagon marked this pull request as ready for review May 29, 2024 09:04
@potatowagon potatowagon changed the title [lexical-list][lexical-playground] Bug fix: support pasting github checklist [lexical-list] Bug fix: support pasting github checklist May 29, 2024
@lexical-bot lexical-bot added the extended-tests Run extended e2e tests on a PR label May 29, 2024
ivailop7
ivailop7 previously approved these changes May 29, 2024
View reviewed changes
StyleT
StyleT previously approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@StyleT StyleT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@potatowagon potatowagon changed the base branch from fix-checkbox-paste to main May 30, 2024 05:27
@potatowagon potatowagon dismissed stale reviews from StyleT and ivailop7 May 30, 2024 05:27

The base branch was changed.

@potatowagon potatowagon requested a review from Sahejkm as a code owner May 30, 2024 05:27
@potatowagon potatowagon added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit e451136 May 30, 2024
37 checks passed
This was referenced Jun 26, 2024
Open
Open
@potatowagon potatowagon deleted the gh-cb-paste branch September 11, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sahejkm Sahejkm Sahejkm approved these changes

@ivailop7 ivailop7 ivailop7 left review comments

@StyleT StyleT StyleT left review comments

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@potatowagon @StyleT @ivailop7 @Sahejkm @facebook-github-bot @lexical-bot