[lexical-react] Bug Fix: checklist cannot be toggled in sub-editors

[AlessioGr]

Description

Checklists within sub-editors do not work. When toggling them, both the click event listeners for the sub-editor, as well as the one for the parent-editor, are triggered. Say the checklist item is untoggled, this would cause the checklist item to be toggled-on and then immediately toggled-off. Visually, it will look like nothing happened at all, as seen in the video.

Adding event.stopPropagation() stops the event from being incorrectly propagated up to the parent

Before

CleanShot.2024-05-30.at.17.06.16.mp4

After

CleanShot.2024-05-30.at.17.05.04.mp4

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 3, 2024 11:12am
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 3, 2024 11:12am

[github-actions]

size-limit report 📦

Path	Size
lexical - cjs	28.33 KB (0%)
lexical - esm	28.14 KB (0%)
@lexical/rich-text - cjs	36.76 KB (0%)
@lexical/rich-text - esm	28.1 KB (0%)
@lexical/plain-text - cjs	35.37 KB (0%)
@lexical/plain-text - esm	25.33 KB (0%)
@lexical/react - cjs	38.52 KB (0%)
@lexical/react - esm	29.12 KB (0%)

[potatowagon]

👍 thanks!

[Sahejkm]

hi @AlessioGr, sorry for the inconvenience caused in the CI do you mind merging latest Main to this branch before we try remerging this PR to main, to make sure all e2e tests are green. Thanks a lot!

[zurfyx]

@AlessioGr We have to revert this as it's breaking internally but feel free to post a follow up PR. While event.stopPropagation() might be correct for this case, it is currently being triggered for every single click on the editor, the scope needs to be revised.