Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-table] CI: Remerge PR 6200 Resizing table with merged cells #6235

Merged
merged 11 commits into from
Jun 3, 2024

Conversation

potatowagon
Copy link
Contributor

@potatowagon potatowagon commented Jun 3, 2024

Description

Credits for the fixes goes to @AlexanderReznik , im just helping to remerge the changes

update: fix the flaky table resize test in collab mode

added a fix for the flaky table resize test in collab mode. sometimes, the height is 87px, sometimes it is 88 px.

using the actual html modification call back introduced in https://github.com/facebook/lexical/pull/6240/commits, accept either 88 or 87 px as html output

Closes #6241

Test plan

npm run start &  npm run test-e2e-chromium

2 flaky
[chromium] › packages/lexical-playground/tests/e2e/ClearFormatting.spec.mjs:109:3 › Clear All Formatting › Should preserve the default styling of hashtags and mentions
[chromium] › packages/lexical-playground/tests/e2e/TextFormatting.spec.mjs:1114:3 › TextFormatting › Regression #2523: can toggle format when selecting a TextNode edge followed by a non TextNode;
20 skipped
415 passed (2.7m)

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 9:03am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 9:03am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

size-limit report 📦

Path Size
lexical - cjs 28.33 KB (0%)
lexical - esm 28.14 KB (0%)
@lexical/rich-text - cjs 36.76 KB (0%)
@lexical/rich-text - esm 28.1 KB (0%)
@lexical/plain-text - cjs 35.37 KB (0%)
@lexical/plain-text - esm 25.33 KB (0%)
@lexical/react - cjs 38.52 KB (0%)
@lexical/react - esm 29.12 KB (0%)

@potatowagon potatowagon removed the extended-tests Run extended e2e tests on a PR label Jun 3, 2024
@AlexanderReznik
Copy link
Contributor

Thank you @potatowagon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilise CI: resolve flaky e2e tests
4 participants