-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-table] CI: Remerge PR 6200 Resizing table with merged cells #6235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potatowagon
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7 and
Sahejkm
as code owners
June 3, 2024 03:02
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jun 3, 2024
size-limit report 📦
|
Sahejkm
approved these changes
Jun 3, 2024
Thank you @potatowagon :) |
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Credits for the fixes goes to @AlexanderReznik , im just helping to remerge the changes
update: fix the flaky table resize test in collab mode
added a fix for the flaky table resize test in collab mode. sometimes, the height is 87px, sometimes it is 88 px.
using the actual html modification call back introduced in https://github.com/facebook/lexical/pull/6240/commits, accept either 88 or 87 px as html output
Closes #6241
Test plan
2 flaky
[chromium] › packages/lexical-playground/tests/e2e/ClearFormatting.spec.mjs:109:3 › Clear All Formatting › Should preserve the default styling of hashtags and mentions
[chromium] › packages/lexical-playground/tests/e2e/TextFormatting.spec.mjs:1114:3 › TextFormatting › Regression #2523: can toggle format when selecting a TextNode edge followed by a non TextNode;
20 skipped
415 passed (2.7m)