Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lexical] Fix missing meta copyright headers in files #6258

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented Jun 5, 2024

What

Fix missing copyright headers in source file issue generated via the Automated Meta Open Source Checks script

Why

Every project specific source file must contain a doc block with an appropriate copyright header. Unrelated files must be listed as exceptions in the Copyright Headers Exceptions page in the repo dashboard.
A copyright header clearly indicates that the code is owned by Meta. Every open source file must start with a comment containing "Meta Platforms, Inc. and affiliates"

TODO

check how to auto include more paths to .eslintrc for copyright headers
https://github.com/facebook/lexical/blob/96bdfb1c859d4d38a19064063bf89958b646ab54/.eslintrc.js

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 3:28am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 3:28am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

size-limit report 📦

Path Size
lexical - cjs 28.33 KB (0%)
lexical - esm 28.14 KB (0%)
@lexical/rich-text - cjs 36.77 KB (0%)
@lexical/rich-text - esm 28.1 KB (0%)
@lexical/plain-text - cjs 35.35 KB (0%)
@lexical/plain-text - esm 25.33 KB (0%)
@lexical/react - cjs 38.51 KB (0%)
@lexical/react - esm 29.12 KB (0%)

@potatowagon
Copy link
Contributor

check how to auto include more paths to .eslintrc for copyright headers

^ i was curious how to do that so looked through:

but i couldnt find a path config. any pointer i could have missed?

@Sahejkm
Copy link
Contributor Author

Sahejkm commented Jun 6, 2024

Looks like an existing marked flaky test failed again. updating the list

@Sahejkm
Copy link
Contributor Author

Sahejkm commented Jun 6, 2024

but i couldnt find a path config. any pointer i could have missed?

i still haven't looked deeply into it yet. will check and see what i can find

@Sahejkm Sahejkm added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit 8f169ba Jun 6, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants