[lexical-playground][lexical-devtools] Fix: Add missing explicit devDependencies for vite config #6291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ependencies for vite config facebook#6280
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
Sahejkm
approved these changes
Jun 11, 2024
StyleT
approved these changes
Jun 11, 2024
|
thank you for fixing this :) I'll try with the next release if we still need |
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few modules used in the vite/wxt builds were missing as explicit devDependencies in lexical-playground and lexical-devtools. This adds them to package.json. There shouldn't be any observable difference in behavior, unless you are trying to extract these projects out of the monorepo or maybe trying to use more strict dependency management tool than npm.
Closes #6280
Test plan
Before
I don't think you could run into any problems with the status quo without doing something unsupported, e.g. #6280, because npm/node will happily just use whatever happens to be present in the workspace root's node_modules.
After
All known dependencies are in the respective package.json files. This probably means that these packages are a bit easier to extract (but there are other "unique" build dependencies like the shared package and invariant that would still make it a bit non-trivial)