Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical] Bug Fix: Export type EditorUpdateOptions #6332

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

etrepum
Copy link
Collaborator

@etrepum etrepum commented Jun 23, 2024

Description

Exports the EditorUpdateOptions type which is used in the public API for LexicalEditor.update

Closes #6331

Test plan

Before

Third party packages couldn't easily reference the EditorUpdateOptions type

Workaround:

import type {LexicalEditor} from 'lexical';
type EditorUpdateOptions = NonNullable<Parameters<LexicalEditor['update']>[1]>;

After

Now they can since it is exported

import type {EditorUpdateOptions} from 'lexical';

Copy link

vercel bot commented Jun 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 6:25pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 6:25pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 23, 2024
Copy link

size-limit report 📦

Path Size
lexical - cjs 28.47 KB (0%)
lexical - esm 28.28 KB (0%)
@lexical/rich-text - cjs 36.91 KB (0%)
@lexical/rich-text - esm 28.09 KB (0%)
@lexical/plain-text - cjs 35.54 KB (0%)
@lexical/plain-text - esm 25.3 KB (0%)
@lexical/react - cjs 38.82 KB (0%)
@lexical/react - esm 29.27 KB (0%)

@Sahejkm Sahejkm added this pull request to the merge queue Jun 24, 2024
Merged via the queue into facebook:main with commit e9efd81 Jun 24, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: EditorUpdateOptions not exported from lexical package
3 participants