Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lexical] Fix broken sync due to deprecation of ReactDOMComet to ReactDOM #6358

Merged
merged 1 commit into from
Jul 1, 2024
Merged

[Lexical] Fix broken sync due to deprecation of ReactDOMComet to ReactDOM #6358

merged 1 commit into from
Jul 1, 2024

Conversation

Sahejkm
Copy link
Contributor

@Sahejkm Sahejkm commented Jul 1, 2024

WHAT

replace mapping for react-dom to ReactDOM from ReactDOMComet

WHY

ReactDOMComet was deprecated 5 days ago to ReactDOM in Meta intern builds

@vercel Vercel
Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 3:14am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 3:14am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 1, 2024
@Sahejkm Sahejkm marked this pull request as ready for review July 1, 2024 03:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

size-limit report 📦

Path Size
lexical - cjs 28.47 KB (0%)
lexical - esm 28.28 KB (0%)
@lexical/rich-text - cjs 36.86 KB (0%)
@lexical/rich-text - esm 28.08 KB (0%)
@lexical/plain-text - cjs 35.49 KB (0%)
@lexical/plain-text - esm 25.3 KB (0%)
@lexical/react - cjs 38.82 KB (0%)
@lexical/react - esm 29.27 KB (0%)

etrepum
etrepum reviewed Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - shouldn't have any effect on OSS

@Sahejkm Sahejkm added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit 63b09cb Jul 1, 2024
42 checks passed
This was referenced Jul 23, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etrepum etrepum etrepum left review comments

@potatowagon potatowagon potatowagon approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sahejkm @etrepum @potatowagon @facebook-github-bot