Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(docs) Add existing history page to navigation #6359

Merged
merged 2 commits into from
Jul 1, 2024
Merged

(docs) Add existing history page to navigation #6359

merged 2 commits into from
Jul 1, 2024

Conversation

TryingToImprove
Copy link
Contributor

Fixes #6348

@vercel Vercel
Copy link

vercel bot commented Jul 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 10:35am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 10:35am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 28.47 KB (0%)
lexical - esm 28.28 KB (0%)
@lexical/rich-text - cjs 36.86 KB (0%)
@lexical/rich-text - esm 28.08 KB (0%)
@lexical/plain-text - cjs 35.49 KB (0%)
@lexical/plain-text - esm 25.3 KB (0%)
@lexical/react - cjs 38.82 KB (0%)
@lexical/react - esm 29.27 KB (0%)

@TryingToImprove
Copy link
Contributor Author

image

Not really sure if that is the title that is expected?

@potatowagon
Copy link
Contributor

potatowagon commented Jul 1, 2024 •
edited
Loading

image

Not really sure if that is the title that is expected?

yea, the title is alittle verbose. have edited packages/lexical-website/docs/concepts/history.md to shorten the title

@potatowagon
Copy link
Contributor

after:

Screenshot 2024-07-01 at 6 35 19 PM

potatowagon
potatowagon approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@potatowagon potatowagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc changes only, safe to merge

@Sahejkm Sahejkm added this pull request to the merge queue Jul 1, 2024
Merged via the queue into facebook:main with commit ad43f66 Jul 1, 2024
8 checks passed
This was referenced Jul 23, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potatowagon potatowagon potatowagon approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Unable to find "concepts/history" on the lexical website
4 participants
@TryingToImprove @potatowagon @facebook-github-bot @Sahejkm