Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-playground][lexical-poll] Bug Fix: Fixes undefined context inside Poll add option #6361

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

romanWebiya
Copy link
Contributor

When lexical parse PollNode, you get error Cannot get getWritable of undefined.
The reason is that this is equal to undefined because of passing addOption function as an argument.

Test plan

Add a poll to initial state
Get error on init, no poll content inside

Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 1:57pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 1:57pm

@facebook-github-bot
Copy link
Contributor

Hi @romanWebiya!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

github-actions bot commented Jul 1, 2024

size-limit report 📦

Path Size
lexical - cjs 28.47 KB (0%)
lexical - esm 28.28 KB (0%)
@lexical/rich-text - cjs 36.86 KB (0%)
@lexical/rich-text - esm 28.08 KB (0%)
@lexical/plain-text - cjs 35.49 KB (0%)
@lexical/plain-text - esm 25.3 KB (0%)
@lexical/react - cjs 38.82 KB (0%)
@lexical/react - esm 29.27 KB (0%)

@ivailop7 ivailop7 added this pull request to the merge queue Jul 1, 2024
Merged via the queue into facebook:main with commit 3bd1351 Jul 1, 2024
34 of 37 checks passed
@ivailop7
Copy link
Collaborator

ivailop7 commented Jul 1, 2024

@romanWebiya could you sign the CLA please. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants