[@lexical/selection] Feature: yield target to style patch fn

[mrdivyansh]

Description

$patchStyleText doesn't expose the target to the CSS property patch function. However, it can be very helpful when the next style value may depend on the target node/selection.

Test plan

Added unit tests

Before

function $patchStyleText(
  selection: BaseSelection,
  patch: Record<
    string,
    | string
    | null
    | (( currentStyleValue: string | null) => string)
  >,
): void

After

function $patchStyleText(
  selection: BaseSelection,
  patch: Record<
    string,
    | string
    | null
    | ((currentStyleValue: string | null, target: TextNode | RangeSelection ) => string)
  >,
): void

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 12, 2024 3:31pm
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 12, 2024 3:31pm

[github-actions]

size-limit report 📦

Path	Size
lexical - cjs	29.39 KB (0%)
lexical - esm	29.17 KB (0%)
@lexical/rich-text - cjs	37.74 KB (0%)
@lexical/rich-text - esm	31.02 KB (0%)
@lexical/plain-text - cjs	36.32 KB (0%)
@lexical/plain-text - esm	28.37 KB (0%)
@lexical/react - cjs	39.65 KB (0%)
@lexical/react - esm	32.47 KB (0%)

[etrepum]

Is there a need to underscore this parameter name? Does it get caught by the eslint shadow rule?

Suggested change

	| ((currentStyleValue: string | null, _target: typeof target) => string)
	| ((currentStyleValue: string | null, target: typeof target) => string)

[mrdivyansh]

Yes, shadow rule complains.

[etrepum]

LGTM, it seems reasonable to pass this information along and it's great that you've also added tests for this feature! One thing that might be a bit counter-intuitive is that the target is not necessarily the same target that is passed to $patchStyle since it will only be a RangeSelection when the given selection is collapsed

[mrdivyansh]

@etrepum , is there anything I need to do to get this PR merged? Thanks for approving the PR.