Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-list][lexical-react] Refactor: Create registerList Function Separate from React Shared Utils #6560

Merged
merged 3 commits into from
Sep 3, 2024
Merged

[lexical-list][lexical-react] Refactor: Create registerList Function Separate from React Shared Utils #6560

merged 3 commits into from
Sep 3, 2024

Conversation

jkjk822
Copy link
Contributor

@jkjk822 jkjk822 commented Aug 26, 2024

  • Create a registerList function similar to other packages register* functions that registers the relevant commands.
  • Refactor the React shared util to use this function instead of defining it inline.

Test plan

N/A, current tests should suffice.

@jkjk822
Create registerList Function Separate from React Shared Utils
0c24fe9 
- Create a registerList function similar to other packages register* functions that registers the relevant commands.
- Refactor the React shared util to use this function instead of defining it inline.
@vercel Vercel
Copy link

vercel bot commented Aug 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 5:01pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 5:01pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 29.38 KB (0%)
lexical - esm 29.22 KB (0%)
@lexical/rich-text - cjs 37.87 KB (0%)
@lexical/rich-text - esm 31.08 KB (0%)
@lexical/plain-text - cjs 36.45 KB (0%)
@lexical/plain-text - esm 28.44 KB (0%)
@lexical/react - cjs 39.64 KB (0%)
@lexical/react - esm 32.52 KB (0%)

@jkjk822 jkjk822 marked this pull request as ready for review August 26, 2024 20:25
@potatowagon potatowagon added the extended-tests Run extended e2e tests on a PR label Aug 29, 2024
@etrepum etrepum added this pull request to the merge queue Sep 3, 2024
Merged via the queue into facebook:main with commit 45991dc Sep 3, 2024
41 checks passed
@jkjk822 jkjk822 deleted the patch-2 branch September 3, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etrepum etrepum etrepum approved these changes

@potatowagon potatowagon potatowagon approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkjk822 @etrepum @potatowagon @facebook-github-bot