Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[lexical-markdown] Fix: normalize markdown in $convertFromMarkdownString to comply with CommonMark spec (#6608)" #6627

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Revert "[lexical-markdown] Fix: normalize markdown in $convertFromMarkdownString to comply with CommonMark spec (#6608)" #6627

merged 1 commit into from
Sep 12, 2024

Conversation

potatowagon
Copy link
Contributor

@potatowagon potatowagon commented Sep 12, 2024 •
edited
Loading

Description

This reverts commit 8123ca7.

The PR introduced a regression in converting tables <-> markdown

sorry @GermanJablo , hope it is alright with you if we revert this for now to patch the regression asap. happy to remerge #6608 once there is a fix for the table <-> markdown conversion

Test plan

Before

Screen.Recording.2024-09-12.at.5.58.46.PM.mov

After

Screen.Recording.2024-09-12.at.5.56.38.PM.mov

@potatowagon
Revert "[lexical-markdown] Fix: normalize markdown in $convertFromMar…
a6295d5 
…kdownString to comply with CommonMark spec (#6608)"

This reverts commit 8123ca7.
@vercel Vercel
Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 10:02am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 10:02am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2024
@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size
lexical - cjs 29.77 KB (0%)
lexical - esm 29.6 KB (0%)
@lexical/rich-text - cjs 38.24 KB (0%)
@lexical/rich-text - esm 31.46 KB (0%)
@lexical/plain-text - cjs 36.82 KB (0%)
@lexical/plain-text - esm 28.86 KB (0%)
@lexical/react - cjs 40.01 KB (0%)
@lexical/react - esm 32.93 KB (0%)

@potatowagon potatowagon added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit b0c9809 Sep 12, 2024
41 checks passed
@GermanJablo GermanJablo mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sahejkm Sahejkm Sahejkm approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@potatowagon @Sahejkm @facebook-github-bot