[lexical-playground][ExcalidrawNode] Bug Fix: Preserve Excalidraw image dimensions after resizing

[neysanfoo]

Description

When resizing an Excalidraw image within the Lexical editor, the new dimensions are not preserved after certain editor actions. For example, try moving the cursor just to the left of the image and pressing Enter. This will cause the image to revert to its original size and a mismatch between the resize box and the image.

Changes Introduced

Updating the ExcalidrawNode Class:

1. Updated updateDOM method to ensure than when node is updated the dom reflects the new width and height
2. Update $createExcalidrawNode function to take in data, width, height

Modifying the ExcalidrawComponent:

1. Retrieved width and height from the node using the new getter methods.
2. Pass width and height to ExcalidrawImage

Updating the ExcalidrawImage Component:

1. Accepted width and height as props.
2. Apply the dimensions to the container's style

Test plan

Steps to Reproduce:

1. Insert an Excalidraw image into the editor.
2. Resize the image to make it larger.
3. Move the cursor to the left of the image.
4. Press Enter.

Before

Observed Behavior: The image shrinks back to its original size, losing the resizing adjustments made by the user.

lexical-bug-before.mp4

After

Observed Behavior: The image retains its resized dimensions, preserving the user's adjustments even after the editor updates.

lexical-bug-after.mp4

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 15, 2024 3:48am
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 15, 2024 3:48am

[facebook-github-bot]

Hi @neysanfoo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[github-actions]

size-limit report 📦

Path	Size
lexical - cjs	29.78 KB (0%)
lexical - esm	29.62 KB (0%)
@lexical/rich-text - cjs	38.21 KB (0%)
@lexical/rich-text - esm	31.51 KB (0%)
@lexical/plain-text - cjs	36.87 KB (0%)
@lexical/plain-text - esm	28.82 KB (0%)
@lexical/react - cjs	40.01 KB (0%)
@lexical/react - esm	32.91 KB (0%)

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[etrepum]

Looks good! Confirmed that resizing works as expected now at least in the situations I tried