-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-markdown] Feature: add ability to hook into the import process for multiline element transformers #6682
Merged
etrepum
merged 6 commits into
facebook:main
from
AlessioGr:feat/hook-into-multiline-transformer-import-process
Oct 16, 2024
Merged
[lexical-markdown] Feature: add ability to hook into the import process for multiline element transformers #6682
etrepum
merged 6 commits into
facebook:main
from
AlessioGr:feat/hook-into-multiline-transformer-import-process
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ElementTransformer
AlessioGr
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
September 27, 2024 23:14
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Sep 27, 2024
size-limit report 📦
|
potatowagon
reviewed
Oct 2, 2024
potatowagon
previously approved these changes
Oct 3, 2024
Hi @potatowagon, just added a test for this feature. Not the simplest one, but an interesting use-case: By default, this would create 2 code blocks. In the newly added test, we use |
etrepum
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
extended-tests
Run extended e2e tests on a PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is similar to #6681 but for multiline element transformers.
This adds a new
handleImportAfterStartMatch
property toMultilineElementTransformer
that allows you to replace whatever happens after theregExpStart
has matched with your own, custom logic.This is great for cases where the default logic for finding the end of a given match and running the
replace
function is not enough.E.g. for JSX elements, we need custom logic to keep track of the amount of opened and closed tags matched in order to find the correct, ending tag. Simply looking for the next closing tag using
regExpEnd
would not work for nested JSX elements. (Example of this in action)