[lexical] Bug Fix: removeText for token text nodes #6688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianmxb
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
adrianmxb
force-pushed
the
fix/removeText-behavior-for-token-text-nodes
branch
from
3a9440b
to
d0c5bc9
Compare
|
The important part to write is the test coverage, otherwise it's hard to confirm that the bug is fixed and a regression is likely to happen again. I started on some of it in #6690 |
|
Closed in favour of #6690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where text nodes in token mode were not being deleted properly when partially removed. According to the documentation, token nodes should be immutable and should be deleted as a whole. However, the current behaviour allowed partial deletion of the text within a token node, resulting in an unexpected mutation into a non-token node.
Describe the changes in this pull request
fixTextadded another condition treating atokennode similiar to an empty text node, effectively removing the node.fixTextnow always returns a node, eliminating the need for the || operator in assignments like firstNode = fixText(firstNode, del) || firstNode;. This simplifies the code and prevents potential undefined errors.Closes #6687
Test plan
Before
After