Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-playground] Bug Fix: toolbar font size input keyboard accessibility #6695

Merged
merged 1 commit into from
Oct 3, 2024
Merged

[lexical-playground] Bug Fix: toolbar font size input keyboard accessibility #6695

merged 1 commit into from
Oct 3, 2024

Conversation

rilrom
Copy link
Contributor

@rilrom rilrom commented Oct 3, 2024

Description

Closes #6694.

Before

toolbar-accessibility.mp4

After

toolbar-accessibility-fixed.mp4

@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 2:04pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 2:04pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

size-limit report 📦

Path Size
lexical - cjs 29.86 KB (0%)
lexical - esm 29.75 KB (0%)
@lexical/rich-text - cjs 38.45 KB (0%)
@lexical/rich-text - esm 31.58 KB (0%)
@lexical/plain-text - cjs 37.09 KB (0%)
@lexical/plain-text - esm 28.95 KB (0%)
@lexical/react - cjs 40.22 KB (0%)
@lexical/react - esm 32.94 KB (0%)

etrepum
etrepum approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice incremental accessibility improvement. If you wanted to go further, it seems that if you type in the font size field then pressing tab will focus the editor instead of the next toolbar item.

@ivailop7 ivailop7 added this pull request to the merge queue Oct 3, 2024
Merged via the queue into facebook:main with commit 9fcd14a Oct 3, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etrepum etrepum etrepum approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: unable to navigate past the font size input in lexical playground toolbar using a keyboard
4 participants
@rilrom @etrepum @facebook-github-bot @ivailop7