Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-playground] Bug Fix: Disable image and inline focusing, adding caption and editing in read-only mode #6705

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

neysanfoo
Copy link
Contributor

Description

Currently, the image and inline image components can still be focused in read-only mode, and the buttons to add caption and edit are still shown.

Changes Introduced In this PR

  • Prevent focusing on images in read-only mode
  • Hide interactive elements in read-only mode

Before

images_readonly_before.mov

After

images_readonly_after.mov

Copy link

vercel bot commented Oct 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 6:17am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 6:17am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2024
Copy link

github-actions bot commented Oct 6, 2024

size-limit report 📦

Path Size
lexical - cjs 29.91 KB (0%)
lexical - esm 29.72 KB (0%)
@lexical/rich-text - cjs 38.55 KB (0%)
@lexical/rich-text - esm 31.6 KB (0%)
@lexical/plain-text - cjs 37.09 KB (0%)
@lexical/plain-text - esm 28.92 KB (0%)
@lexical/react - cjs 40.29 KB (0%)
@lexical/react - esm 32.99 KB (0%)

@etrepum etrepum added this pull request to the merge queue Oct 16, 2024
Merged via the queue into facebook:main with commit 0e4b434 Oct 16, 2024
39 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants