[lexical-table] Bug Fix: colWidths not imported from DOM for TableNode
#6731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwstra
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
size-limit report 📦
|
etrepum
reviewed
Oct 15, 2024
| } | ||
| columns.push(parseFloat(width)); | ||
| } | ||
| if (columns) {tableNode.setColWidths(columns);} |
There was a problem hiding this comment.
I don't think this will pass the prettier check, you can npm run prettier:fix to fix it and npm run ci-check to verify that the syntax/type/link checks pass locally
There was a problem hiding this comment.
Done, along with patching up an e2e test that was (positively) affected by this change. Getting type errors inside of lexical-code when running the ci-check locally. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
lexical-tableserializes column widths to the DOM, but doesn't read them. This should remedy that situation.Closes #6685
Test plan
The playground does not have a convenient way to demonstrate this, though I did update the relevant unit test to incorporate reading the column width.