Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical] Chore: Enable all selection tests on Mac #6739

Closed
wants to merge 2 commits into from

Conversation

etrepum
Copy link
Collaborator

@etrepum etrepum commented Oct 16, 2024

Description

Some selection tests were disabled on Mac, possibly for some legacy reason (maybe before the meta/ctrl key press in tests was abstracted?), but they all work because we have keybindings for each of the actions they are performing.

Test plan

Before

Fewer selection tests ran on Mac

After

All selection tests run on Mac

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 0:45am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 0:45am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

size-limit report 📦

Path Size
lexical - cjs 29.94 KB (0%)
lexical - esm 29.78 KB (0%)
@lexical/rich-text - cjs 38.51 KB (0%)
@lexical/rich-text - esm 31.58 KB (0%)
@lexical/plain-text - cjs 37.16 KB (0%)
@lexical/plain-text - esm 29 KB (0%)
@lexical/react - cjs 40.29 KB (0%)
@lexical/react - esm 33 KB (0%)

@etrepum
Copy link
Collaborator Author

etrepum commented Oct 16, 2024

The logic here was inverted, the tests are skipped when NOT on mac. I don't have an easy way to test that so I am abandoning this PR.

@etrepum etrepum deleted the enable-mac-selection-tests branch October 16, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants