Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-react] replace abstract component #6752

Merged
merged 8 commits into from
Oct 25, 2024
Merged

[lexical-react] replace abstract component #6752

merged 8 commits into from
Oct 25, 2024

Conversation

potatowagon
Copy link
Contributor

@potatowagon potatowagon commented Oct 21, 2024 •
edited
Loading

AbstractComponent got killed in www, replacing it with its substitute

testplan: ran flow in www. this is syncing the changes

updated flow bin to the version that has component syntax

@vercel Vercel
Copy link

vercel bot commented Oct 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 8:27am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 8:27am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 29.94 KB (0%)
lexical - esm 29.78 KB (0%)
@lexical/rich-text - cjs 38.6 KB (0%)
@lexical/rich-text - esm 31.64 KB (0%)
@lexical/plain-text - cjs 37.2 KB (0%)
@lexical/plain-text - esm 29 KB (0%)
@lexical/react - cjs 40.34 KB (0%)
@lexical/react - esm 33 KB (0%)

@potatowagon potatowagon marked this pull request as draft October 21, 2024 21:19
@potatowagon potatowagon marked this pull request as ready for review October 25, 2024 08:26
@zurfyx zurfyx added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit e96ee55 Oct 25, 2024
36 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@potatowagon @zurfyx @facebook-github-bot