Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty line issue #6777

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix empty line issue #6777

wants to merge 1 commit into from

Conversation

Shopiley
Copy link
Contributor

@Shopiley Shopiley commented Oct 29, 2024

Description

Currently, empty lines on markdown disappear when the markdown button is toggled.
This pull request aim to ensure empty lines are maintained upon toggling markdown.
I realised that setting a variable called shouldPreserveNewLines to true across all instances it was used seemed to fix the issue.

Closes 4838

Test plan

Before

Insert relevant screenshots/recordings/automated-tests

After

Insert relevant screenshots/recordings/automated-tests

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 5:25pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 5:25pm

@facebook-github-bot
Copy link
Contributor

Hi @Shopiley!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

size-limit report 📦

Path Size
lexical - cjs 29.92 KB (0%)
lexical - esm 29.75 KB (0%)
@lexical/rich-text - cjs 38.57 KB (0%)
@lexical/rich-text - esm 31.65 KB (0%)
@lexical/plain-text - cjs 37.18 KB (0%)
@lexical/plain-text - esm 28.94 KB (0%)
@lexical/react - cjs 40.24 KB (0%)
@lexical/react - esm 33.01 KB (0%)

Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current default markdown behavior needs to be preserved for backwards compatibility reasons. The issue here is that it might be hard for users to discover this setting because there is a lack of documentation in the markdown package about this setting and the expected behavior. Unfortunately markdown is quite a complex specification mostly because there are many different ones (commonmark, github flavored markdown, mdx, other extensions etc.), many of them have conflicting requirements, and I think what has been accidentally created here is yet another "lexical markdown" spec which is not well defined but certain applications depend on exactly how it behaves now.

@Shopiley
Copy link
Contributor Author

Shopiley commented Nov 3, 2024

Okay, so what I have to do is experiment with this setting and document the expected behaviour.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: support empty line in markdown
3 participants