-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix empty line issue #6777
base: main
Are you sure you want to change the base?
fix empty line issue #6777
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @Shopiley! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current default markdown behavior needs to be preserved for backwards compatibility reasons. The issue here is that it might be hard for users to discover this setting because there is a lack of documentation in the markdown package about this setting and the expected behavior. Unfortunately markdown is quite a complex specification mostly because there are many different ones (commonmark, github flavored markdown, mdx, other extensions etc.), many of them have conflicting requirements, and I think what has been accidentally created here is yet another "lexical markdown" spec which is not well defined but certain applications depend on exactly how it behaves now.
Okay, so what I have to do is experiment with this setting and document the expected behaviour. |
Description
Currently, empty lines on markdown disappear when the markdown button is toggled.
This pull request aim to ensure empty lines are maintained upon toggling markdown.
I realised that setting a variable called
shouldPreserveNewLines
to true across all instances it was used seemed to fix the issue.Closes 4838
Test plan
Before
Insert relevant screenshots/recordings/automated-tests
After
Insert relevant screenshots/recordings/automated-tests