Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-link] Test: Removing link from node(children) #6817

Merged
merged 10 commits into from
Nov 15, 2024
Merged

[lexical-link] Test: Removing link from node(children) #6817

merged 10 commits into from
Nov 15, 2024
+70 −0

Conversation

vantage-ola
Copy link
Contributor

Description

Test for removing link from a text node, when the node has children (like mark node)

Closes #6665

@vercel Vercel
Copy link

vercel bot commented Nov 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 6:43pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 6:43pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 30.85 KB (0%)
lexical - esm 30.73 KB (0%)
@lexical/rich-text - cjs 39.58 KB (0%)
@lexical/rich-text - esm 32.67 KB (0%)
@lexical/plain-text - cjs 38.22 KB (0%)
@lexical/plain-text - esm 29.93 KB (0%)
@lexical/react - cjs 41.35 KB (0%)
@lexical/react - esm 34.03 KB (0%)

@vantage-ola vantage-ola marked this pull request as ready for review November 13, 2024 08:16
@vantage-ola
Copy link
Contributor Author

overall, apart from those suggested fixes. is the approach good to go?

@etrepum etrepum added this pull request to the merge queue Nov 15, 2024
Merged via the queue into facebook:main with commit e2396e4 Nov 15, 2024
37 of 40 checks passed
@vantage-ola vantage-ola deleted the test-link-from-desc branch November 15, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etrepum etrepum etrepum approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test for removing link from a node
3 participants
@vantage-ola @etrepum @facebook-github-bot