Fix triple-click selection on chromium

[acywatson]

Workaround for chromium issue:

https://bugs.chromium.org/p/chromium/issues/detail?id=575136

[trueadm]

Couldn't selection.anchor.getNode() be a block node too?

[trueadm]

Also you should never really mutate the focus or anchor points like this, instead prefer using the set method.

[acywatson]

Also you should never really mutate the focus or anchor points like this, instead prefer using the set method.

I was curious about this - decided to just wait for your comments in the PR instead of asking. Good to know.

[trueadm]

I'm curious what bug the triple click brings? It seems to occur in other editors too. Why does patching it matter? I guess there are two things:

• if we are trying to patch Outline's internal model so that it doesn't select both blocks, this change should maybe live in OutlineSelection, like I mentioned on work chat.
• if you want to update Outline and also physically move the browser native selection into the previous node, then it shouldn't live in OutlineSelection, as that trigger a reconcileSelection.

[acywatson]

I'm curious what bug the triple click brings? It seems to occur in other editors too. Why does patching it matter? I guess there are two things:

• if we are trying to patch Outline's internal model so that it doesn't select both blocks, this change should maybe live in OutlineSelection, like I mentioned on work chat.
• if you want to update Outline and also physically move the browser native selection into the previous node, then it shouldn't live in OutlineSelection, as that trigger a reconcileSelection.

The bug occurs in a pretty basic use case. if I type two lines of text (two paragraphs) then I triple click to select the entire first one and try to format it to Bold or something, that style gets applied to the entire second paragraph as well. I don't think this can be considered "sane" behavior, from a UX standpoint, even if other editors are doing it that way.

The Gmail composer doesn't have this behavior, neither does Quip, just from a cursory glance.

Something else we can consider is whether it makes sense to just patch it in the BizComposer. Maybe it doesn't need to be in Outline at all.

[trueadm]

Aha, Triple click here isn’t the bug. Rather there’s a bug with the format logic.

e. if I type two lines of text (two paragraphs) then I triple click to select the entire first one and try to format it to Bold or something, that style gets applied to the entire second paragraph as well.

if you’re selecting a text node at offset 0, we shouldn’t be applying any formatting or styling to that node, it should be skipped.

[trueadm]

Awesome stuff! :)

[zurfyx]

Should we fix this here? AFAIK the problem is with the split text logic. Usually you want to handle index case 0, because otherwise instead of the expected [before, after] you get [after, undefined]. Which sounds like the logic you've introduced after to address this

Suggested change

	// if the entire last node isn't selected, split it
	if (endOffset !== lastNodeTextLength) {
	[lastNode] = lastNode.splitText(endOffset);
	}
	// if the entire last node isn't selected, split it
	if (endOffset !== 0) {
	if (endOffset !== lastNodeTextLength) {
	[lastNode] = lastNode.splitText(endOffset);
	}
	lastNode.setFormat(lastNextFormat);
	}

[zurfyx]

Suggested change

	const isBefore = anchor.isBefore(focus);
	const isBefore = selection.isBackward();