Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix TextInput never unset MovementMethod
Summary: Since we never unset `MovementMethod` when we unmount `EditText`: https://www.internalfb.com/code/fbsource/[c3c455bf992e271a11603f404e7de719868be3da]/fbandroid/libraries/components/litho-widget/src/main/java/com/facebook/litho/widget/TextInputSpec.java?lines=942-949 We could potentially face a situation where the `TextView.layout` has been released when we're dealing with logic inside the callback `MovementMethod`, for example: https://www.internalfb.com/code/fbsource/[c0dfc5d86d8051e0861c1abc35cb0e9647c6fd00]/fbandroid/java/com/facebook/widget/text/BetterLinkMovementMethod.kt?lines=30-68 It might lead to a crash like this: https://fburl.com/logview/9cgol7zq Reviewed By: jettbow Differential Revision: D67088678 fbshipit-source-id: 633af90a840ba08ac4b79acce8368ce0a3ebac8b
- Loading branch information