Ship Primitive image component

Summary: The experiment was neutral, all issues have been addressed so I'm shipping primitive implementation of image component and removing mount spec version.

Reviewed By: pentiumao

Differential Revision: D66643554

fbshipit-source-id: ea7d4faa914741253df44957b371a15531e39e56

litho-core/src/main/java/com/facebook/litho/config/ComponentsConfiguration.kt

@@ -264,11 +264,6 @@ internal constructor(
     /** This flag is used to enable a fix for the ANR issue with sticky header RecyclerView. */
     @JvmField var enableFixForStickyHeader: Boolean = false
 
-    /**
-     * This flag is used to enable using PrimitiveComponent implementation of an Image component.
-     */
-    @JvmField var usePrimitiveImage: Boolean = false
-
     /**
      * This flag is used to enable using PrimitiveComponent implementation of a SolidColor
      * component.

litho-widget/src/main/java/com/facebook/litho/widget/ExperimentalImage.kt

@@ -24,7 +24,6 @@ import com.facebook.litho.MatrixDrawable
 import com.facebook.litho.PrimitiveComponent
 import com.facebook.litho.PrimitiveComponentScope
 import com.facebook.litho.Style
-import com.facebook.litho.annotations.ExperimentalLithoApi
 import com.facebook.rendercore.Size
 import com.facebook.rendercore.SizeConstraints
 import com.facebook.rendercore.primitives.DrawableAllocator
@@ -46,7 +45,6 @@ import kotlin.math.max
  * @param useIntrinsicSize Whether to use the intrinsic size of the [drawable] for component
  *   measurement.
  */
-@ExperimentalLithoApi
 class ExperimentalImage(
     private val drawable: Drawable?,
     private val scaleType: ScaleType = ScaleType.FIT_CENTER,

litho-widget/src/main/java/com/facebook/litho/widget/ImageSpec.kt

@@ -21,14 +21,12 @@ import android.widget.ImageView
 import com.facebook.litho.Component
 import com.facebook.litho.ComponentContext
 import com.facebook.litho.annotations.ExcuseMySpec
-import com.facebook.litho.annotations.ExperimentalLithoApi
 import com.facebook.litho.annotations.LayoutSpec
 import com.facebook.litho.annotations.OnCreateLayout
 import com.facebook.litho.annotations.Prop
 import com.facebook.litho.annotations.PropDefault
 import com.facebook.litho.annotations.Reason
 import com.facebook.litho.annotations.ResType
-import com.facebook.litho.config.ComponentsConfiguration
 
 /**
  * A component that is able to display drawable resources. It takes a drawable resource ID as prop.
@@ -43,22 +41,14 @@ object ImageSpec {
 
   @PropDefault val useIntrinsicSize: Boolean = true
 
-  @OptIn(ExperimentalLithoApi::class)
   @OnCreateLayout
   fun onCreateLayout(
       c: ComponentContext,
       @Prop(resType = ResType.DRAWABLE) drawable: Drawable?,
       @Prop(optional = true) scaleType: ImageView.ScaleType?,
       @Prop(optional = true) useIntrinsicSize: Boolean,
   ): Component {
-    return if (ComponentsConfiguration.usePrimitiveImage) {
-      ExperimentalImage(drawable, scaleType ?: ImageView.ScaleType.FIT_CENTER, useIntrinsicSize)
-    } else {
-      ImageComponent.create(c)
-          .drawable(drawable)
-          .scaleType(scaleType ?: ImageView.ScaleType.FIT_CENTER)
-          .useIntrinsicSize(useIntrinsicSize)
-          .build()
-    }
+    return ExperimentalImage(
+        drawable, scaleType ?: ImageView.ScaleType.FIT_CENTER, useIntrinsicSize)
   }
 }