Rename default mount behavior

Summary: Just clean up to make it easier to reason when adding new strategies for mount behavior. Differential Revision: D62964108 fbshipit-source-id: c17c7b885646f513357195187f61dee6079d9c46
facebook · Oct 1, 2024 · 9d58f21 · 9d58f21
1 parent ff7c1fd
commit 9d58f21
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/litho-core/src/main/java/com/facebook/litho/config/ComponentsConfiguration.kt b/litho-core/src/main/java/com/facebook/litho/config/ComponentsConfiguration.kt
@@ -106,7 +106,7 @@ internal constructor(
      */
     @JvmField
     val primitiveRecyclerBinderStrategy: PrimitiveRecyclerBinderStrategy =
-        PrimitiveRecyclerBinderStrategy.RECYCLER_SPEC_EQUIVALENT_AND_ITEM_DECORATION,
+        PrimitiveRecyclerBinderStrategy.DEFAULT,
     /**
      * This flag is used to enable a fix for the issue where components that match the host view
      * size do not get unmounted when they go out of the viewport.

diff --git a/litho-core/src/main/java/com/facebook/litho/config/PrimitiveRecyclerBinderStrategy.kt b/litho-core/src/main/java/com/facebook/litho/config/PrimitiveRecyclerBinderStrategy.kt
@@ -24,6 +24,9 @@ enum class PrimitiveRecyclerBinderStrategy {
    */
   SPLIT_BINDERS,
 
-  /** In this strategy we only remove the item decoration binding from the original approach. */
-  RECYCLER_SPEC_EQUIVALENT_AND_ITEM_DECORATION
+  /**
+   * In this strategy, we are using the original RecyclerSpec Mount and Bind binders, and a separate
+   * one for the item decoration
+   */
+  DEFAULT
 }
diff --git a/litho-widget/src/main/java/com/facebook/litho/widget/Recycler.kt b/litho-widget/src/main/java/com/facebook/litho/widget/Recycler.kt
@@ -46,7 +46,6 @@ import com.facebook.rendercore.primitives.PrimitiveLayoutResult
 import com.facebook.rendercore.primitives.ViewAllocator
 import com.facebook.rendercore.toHeightSpec
 import com.facebook.rendercore.toWidthSpec
-import java.lang.IllegalStateException
 import kotlin.math.max
 
 class Recycler
@@ -117,8 +116,8 @@ constructor(
                   recyclerEventsController,
                   measureChild.value,
               )
-          PrimitiveRecyclerBinderStrategy.RECYCLER_SPEC_EQUIVALENT_AND_ITEM_DECORATION ->
-              RecyclerSpecEquivalentAndItemDecorationMountBehavior(
+          PrimitiveRecyclerBinderStrategy.DEFAULT ->
+              DefaultMountBehavior(
                   measureVersion,
                   onRefresh,
                   onScrollListeners,
@@ -142,7 +141,7 @@ constructor(
         style = style)
   }
 
-  private fun PrimitiveComponentScope.RecyclerSpecEquivalentAndItemDecorationMountBehavior(
+  private fun PrimitiveComponentScope.DefaultMountBehavior(
       measureVersion: State<Int>,
       onRefresh: (() -> Unit)?,
       onScrollListeners: List<RecyclerView.OnScrollListener>?,