Add errata for fix to marginStart/End for row-reverse flex direction #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D50145273 |
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Oct 12, 2023
Summary: X-link: facebook/litho#961 X-link: facebook/react-native#40803 This stack is ultimately aiming to solve facebook#1208 This adds an value to the Errata enum. I will use this to gate this fix as there is potential for users to rely on this bug or have a hack in place to fix it and this would be a breaking change. Reviewed By: NickGerleman Differential Revision: D50145273
joevilches
pushed a commit
to joevilches/litho
that referenced
this pull request
Oct 12, 2023
…acebook#961) Summary: X-link: facebook/react-native#40803 This stack is ultimately aiming to solve facebook/yoga#1208 This adds an value to the Errata enum. I will use this to gate this fix as there is potential for users to rely on this bug or have a hack in place to fix it and this would be a breaking change. Reviewed By: NickGerleman Differential Revision: D50145273
joevilches
force-pushed
the
export-D50145273
branch
from
b284475
to
35bc03b
Compare
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Oct 12, 2023
…acebook#40803) Summary: X-link: facebook/litho#961 This stack is ultimately aiming to solve facebook/yoga#1208 This adds an value to the Errata enum. I will use this to gate this fix as there is potential for users to rely on this bug or have a hack in place to fix it and this would be a breaking change. Reviewed By: NickGerleman Differential Revision: D50145273
|
This pull request was exported from Phabricator. Differential Revision: D50145273 |
…acebook#961) Summary: X-link: facebook/yoga#1419 X-link: facebook/react-native#40803 This stack is ultimately aiming to solve facebook/yoga#1208 This adds an value to the Errata enum. I will use this to gate this fix as there is potential for users to rely on this bug or have a hack in place to fix it and this would be a breaking change. Reviewed By: NickGerleman Differential Revision: D50145273
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Oct 12, 2023
…acebook#1419) Summary: X-link: facebook/litho#961 X-link: facebook/react-native#40803 This stack is ultimately aiming to solve facebook#1208 This adds an value to the Errata enum. I will use this to gate this fix as there is potential for users to rely on this bug or have a hack in place to fix it and this would be a breaking change. Reviewed By: NickGerleman Differential Revision: D50145273
joevilches
force-pushed
the
export-D50145273
branch
from
35bc03b
to
a548d11
Compare
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Oct 12, 2023
…acebook#40803) Summary: X-link: facebook/yoga#1419 X-link: facebook/litho#961 This stack is ultimately aiming to solve facebook/yoga#1208 This adds an value to the Errata enum. I will use this to gate this fix as there is potential for users to rely on this bug or have a hack in place to fix it and this would be a breaking change. Reviewed By: NickGerleman Differential Revision: D50145273
|
This pull request was exported from Phabricator. Differential Revision: D50145273 |
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Oct 12, 2023
…1419) Summary: Pull Request resolved: #1419 X-link: facebook/litho#961 X-link: facebook/react-native#40803 This stack is ultimately aiming to solve #1208 This adds an value to the Errata enum. I will use this to gate this fix as there is potential for users to rely on this bug or have a hack in place to fix it and this would be a breaking change. Reviewed By: NickGerleman Differential Revision: D50145273 fbshipit-source-id: 913d2103cd31c1fa94cb39fc15d05b0c0b255920
|
This pull request has been merged in 5b1132b. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Oct 12, 2023
…40803) Summary: X-link: facebook/yoga#1419 X-link: facebook/litho#961 Pull Request resolved: #40803 This stack is ultimately aiming to solve facebook/yoga#1208 This adds an value to the Errata enum. I will use this to gate this fix as there is potential for users to rely on this bug or have a hack in place to fix it and this would be a breaking change. Reviewed By: NickGerleman Differential Revision: D50145273 fbshipit-source-id: 913d2103cd31c1fa94cb39fc15d05b0c0b255920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This stack is ultimately aiming to solve facebook/yoga#1208
This adds an value to the Errata enum. I will use this to gate this fix as there is potential for users to rely on this bug or have a hack in place to fix it and this would be a breaking change.
Differential Revision: D50145273