Skip to content

Commit

Permalink
Don't call mcrouter --help at the end of the build script
Browse files Browse the repository at this point in the history
Summary: mcrouter --help exits with nonzero status code, which causes the whole script to have nonzero code.

Test Plan: verify the script has 0 status on successful build

Reviewed By: pavlo@fb.com

Subscribers: meyering, alikhtarov

FB internal diff: D1561594

Tasks: 5175834
  • Loading branch information
alikhtarov committed Sep 17, 2014
1 parent 5a7b852 commit 3841348
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mcrouter/scripts/get_and_build_everything.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ for script in $(ls "order_$ORDER/" | egrep '^[0-9]+_.*[^~]$' | sort -n); do
"./order_$ORDER/$script" "$PKG_DIR" "$INSTALL_DIR" "$MAKE_ARGS"
done

"$INSTALL_DIR/bin/mcrouter" --help
printf "%s\n" "Mcrouter installed in $INSTALL_DIR/bin/mcrouter"

1 comment on commit 3841348

@jamescarr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I had actually just nuked the line in my branch to get past it but never did a PR :-/

Please sign in to comment.